[libvirt] [libvirt-glib] gobject, gconfig: Drop redundant debug logging

Daniel P. Berrange berrange at redhat.com
Thu Dec 3 14:49:16 UTC 2015


On Thu, Dec 03, 2015 at 02:43:32PM +0000, Zeeshan Ali (Khattak) wrote:
> Justification from IRC chat:
> 
> <zeenix> danpb: i'm not sure it's good to have a g_debug() for every
>          libvirt-gobject/gconfig object creation/destruction
> <zeenix> danpb: the debug output becomes so big that at least I never
>          think about enabling it at runtime and sometimes end up missing
>          important debug info
> <danpb>  yeah we could easily kill that
> <danpb>  gobject has systemtap probes builtin these days which let you
>          debug object create/finalize problems
> <zeenix> danpb: oh cool
> <zeenix> danpb: i'll write a patch

The commit message could better say:

  "The g_debug messages in libvirt-gobject creation/destruction
   were to aid troubleshooting of object reference leaks. GObject
   has built-in systemtap probes that allow the same to be achieved
   in a more flexible manner, so the g_debug calls can be removed"

ACK with that change.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list