[libvirt] [PATCH v2 0/5] Add read error ignore to storage backend vol info APIs

[Ján Tomko]

On Tue, Nov 24, 2015 at 03:57:11PM -0500, John Ferlan wrote:
> v1 took a simplistic approach:
> 
> http://www.redhat.com/archives/libvir-list/2015-October/msg00919.html
> 
> but not specific enough according to the review. So adding some extra
> complexity of checking for specific errors and flag bits to "ignore" the
> error similar to the catch-all openflags VIR_STORAGE_VOL_OPEN_NOERROR for
> all the virStorageBackendUpdateVol{Info|TargetInfo|TargetInfoFD} API's
> which are used to get the volume capacity, allocation, etc. data.
> 
> Along the way an inavertent bug was found and fixed in patch 3 in
> virStorageBackendUpdateVolTargetInfo where an error could have been
> reported, but not propagated back to the user since 'ret' would have
> been 0 after the virStorageBackendUpdateVolTargetInfoFD call.
> 
> 
> John Ferlan (5):
>   storage: Add readflags for backend error processing
>   storage: Add comments for backend APIs
>   storage: Handle readflags errors
>   storage: Add debug message
>   storage: Ignore block devices that fail format detection
> 
>  src/storage/storage_backend.c         | 151 +++++++++++++++++++++++++++-------
>  src/storage/storage_backend.h         |  20 ++++-
>  src/storage/storage_backend_disk.c    |   5 +-
>  src/storage/storage_backend_fs.c      |   8 +-
>  src/storage/storage_backend_gluster.c |   2 +-
>  src/storage/storage_backend_logical.c |   2 +-
>  src/storage/storage_backend_mpath.c   |   2 +-
>  src/storage/storage_backend_scsi.c    |   6 +-
>  8 files changed, 153 insertions(+), 43 deletions(-)
> 

ACK series, with one comment on patch 3/5.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151204/7716b35f/attachment-0001.sig>