[libvirt] [PATCH 0/4] Some ABI incompatible changes to virtlogd

[John Ferlan]

On 12/04/2015 10:53 AM, Daniel P. Berrange wrote:
> Having looked at the code again there is a wire-ABI incompatible
> change I think we should make to virtlogd to make it more
> flexible. Since we've not released 1.3.0 yet, this is the only
> chance we'll have to change the wire protocol. There are also
> a couple of fixes in this series we should have before release.
> 
> Daniel P. Berrange (4):
>   qemu: fix memory leak in opening log file
>   logging: preserve driver, dom name & uuid against log file
>   logging: change log protocol to be more reusable
>   logging: validate flags passed from client in virtlogd
> 
>  src/logging/log_daemon_dispatch.c |  14 ++--
>  src/logging/log_handler.c         | 135 +++++++++++++++++++-------------------
>  src/logging/log_handler.h         |  14 ++--
>  src/logging/log_manager.c         |  18 ++---
>  src/logging/log_manager.h         |   9 +--
>  src/logging/log_protocol.x        |   7 +-
>  src/qemu/qemu_domain.c            |  47 ++++++-------
>  7 files changed, 114 insertions(+), 130 deletions(-)
> 

Oh how best to warn everyone to shutdown everything before installing or
updating to this code once pushed and built...  Where will the first
complaint come from?  Is there a pool?  If the VERSION value changes
would that at least make sure something doesn't go awry for those that
already have logd running?

In general though, the changes seem reasonable to me.

ACK series, although patch 2 did have some adjustments.

John