[libvirt] [PATCH 5/7] libxl: copy persistent domain definition while starting a guest

Erik Skultety eskultet at redhat.com
Tue Dec 8 16:20:00 UTC 2015


On 04/12/15 20:30, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---

commit message again, also the subject says "copy", but copy where,
"save persistent domain" might be better wording I think.

>  src/libxl/libxl_domain.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
> index ef92974..9551f2e 100644
> --- a/src/libxl/libxl_domain.c
> +++ b/src/libxl/libxl_domain.c
> @@ -995,6 +995,10 @@ libxlDomainStart(libxlDriverPrivatePtr driver, virDomainObjPtr vm,
>          VIR_FREE(managed_save_path);
>      }
>  
> +    if (virDomainObjSetDefTransient(cfg->caps, driver->xmlopt,
> +                                    vm, true) < 0)
> +        goto cleanup;
> +
>      if (libxlBuildDomainConfig(driver->reservedGraphicsPorts, vm->def,
>                                 cfg->ctx, &d_config) < 0)
>          goto cleanup;
> 

ACK with those adjustments mentioned above.

Erik




More information about the libvir-list mailing list