[libvirt] [PATCH] qemu: Warn when using vhost-user without shared memory
Martin Kletzander
mkletzan at redhat.com
Tue Dec 8 17:31:16 UTC 2015
On Tue, Dec 08, 2015 at 09:22:35AM -0700, Eric Blake wrote:
>On 12/08/2015 08:24 AM, Martin Kletzander wrote:
>> When user configures vhost-user interface and forgets to also configure
>> any shared memory, the search for the root cause of non-operational
>> interface might take unpleasantly long time. Let's enhance user
>> experience by emitting a warning in the logs.
>>
>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1266982
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>> src/qemu/qemu_process.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>>
>
>> + /*
>> + * This check is by no means complete. We merely check
>> + * whetere there are *some* hugepages enabled and *some* NUMA
>
>s/whetere/whether/
>
>ACK with the spelling fix
>
Thanks for the review, I fixed the spelling and I'll push it after the
release in case there are any controversies caused by that.
>
>--
>Eric Blake eblake redhat com +1-919-301-3266
>Libvirt virtualization library http://libvirt.org
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20151208/eba338d4/attachment-0001.sig>
More information about the libvir-list
mailing list