[libvirt] [PATCHv2 3/4] qemu: Implement share memory device hot-plug

John Ferlan jferlan at redhat.com
Thu Dec 10 01:26:45 UTC 2015


[...]

> +int
> +qemuDomainAttachShmemDevice(virQEMUDriverPtr driver,
> +                            virDomainObjPtr vm,
> +                            virDomainShmemDefPtr shmem)
> +{
> +    int ret = -1;
> +    qemuDomainObjPrivatePtr priv = vm->privateData;
> +    char *devstr = NULL;
> +    char *charAlias = NULL;

Dang... one more thing... why no?

   if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE)) {
        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                       _("qemu does not support -device"));
        return -1;
    }

I see it's not in AttachRNG (so why it was missed), *BUT* it is in
DetachRNG... So it seems a separate patch for AttachRNG should add that?

John




More information about the libvir-list mailing list