[libvirt] [PATCH v2 0/7] Add multiqueue support for macvtaps

[Michal Privoznik]

On 10.12.2015 17:52, Laine Stump wrote:
> On 12/10/2015 02:38 AM, Michal Privoznik wrote:
>> Patches 1, 2, 3, 6, 7 have been ACKed in previous round. However, I did
>> slightly change them to reflect Laine's review suggestions.
>> Patch 4 has not been ACKed yet, patch 5 is new.
>>
>> Michal Privoznik (7):
>>    virNetDevMacVLanCreateWithVPortProfile: Turn vnet_hdr into flag
>>    virNetDevMacVLanTapOpen: Slightly rework
>>    virNetDevMacVLanTapOpen: Rework to support multiple FDs
>>    virNetDevMacVLanTapSetup: Rework to support multiple FDs
>>    virNetDevMacVLanTapSetup: Allow enabling of IFF_MULTI_QUEUE
>>    virNetDevMacVLanCreateWithVPortProfile: Rework to support multiple FDs
>>    qemu: Enable multiqueue for macvtaps
>>
>>   src/lxc/lxc_process.c       |   3 +-
>>   src/qemu/qemu_command.c     |  65 ++++++++++------
>>   src/qemu/qemu_command.h     |   2 +
>>   src/qemu/qemu_hotplug.c     |  16 ++--
>>   src/util/virnetdevmacvlan.c | 185
>> ++++++++++++++++++++++----------------------
>>   src/util/virnetdevmacvlan.h |   7 +-
>>   6 files changed, 153 insertions(+), 125 deletions(-)
>>
> 
> For some reason 5/7 and 6/7 didn't get delivered to me (although they
> are in the list archive).

Weird. Same here ....

> I have a suggestion for slight rewording of
> the function description in 5/7, which I'll list here, but otherwise ACK
> for the series.
> 
> 
>> * Turn the IFF_VNET_HDR flag, if requested and available, make sure it's
>> * off in the other cases. Similarly, IFF_MULTI_QUEUE is enabled if
>> * requested. However, if requested and failed to set, it is considered a
>> * fatal error (as opposed to @vnet_hdr).
> 
> Instead maybe:
> 
>   "Turn on the IFF_VNET_HDR flag if requested and available, but make sure
>   it's off otherwise. Similarly, turn on IFF_MULTI_QUEUE if requested, but
>   if it can't be set, consider it a fatal error (rather than ignoring as
>   with @vnet_hdr)."
> 

Thanks, fixed and pushed.

Michal