[libvirt] [PATCH 2/2] qemu: Add support for zero-detection writes

[Vasiliy Tolstov]

2015-12-14 13:17 GMT+03:00 Martin Kletzander <mkletzan at redhat.com>:
> There is a slight problem here.  The parameter in QEMU is called
> detect_zeroes, but we use "zeros" a tiny bit more in our code and
> documentation.  I went with "zeros" to be consistent, but it might
> confuse some people.  However, the other way around might be as
> confusing as this one, but we need to choose one.


Thanks, i'm try to test this patch series and get error:
ОШИБКА: internal error: process exited while connecting to monitor:
2015-12-14T12:36:44.438611Z qemu-system-x86_64: -drive
file=/dev/vg3/41459,if=none,id=drive-scsi0-0-0-0,format=raw,cache=none,discard=unmap,detect_zeros=unmap,aio=native:
Block format 'raw' used by device 'drive-scsi0-0-0-0' doesn't support
the option 'detect_zeros'

my relevant libvirt xml:
<disk type='block' device='disk'>
          <driver name='qemu' type='raw' cache='none' io='native'
discard='unmap' detect_zeros='unmap' />
          <source dev='/dev/{nodes_storage_pool}/{name}'/>
          <alias name='scsi-disk0'/>
          <target dev='sda' bus='scsi'/>
          <address type='drive' controller='0' bus='0' unit='0'/>
</disk>


Also my help message for qemu (2.5.0-rc3) does not have
"detect_zeroes", but "detect-zeroes", not _ but -

-- 
Vasiliy Tolstov,
e-mail: v.tolstov at selfip.ru