[libvirt] [PATCH 2/3] tools: Include PIE_LDFLAGS at the correct place

Michal Privoznik mprivozn at redhat.com
Mon Dec 21 08:31:48 UTC 2015


This is no functional change, but I find it disturbing that
something_LDADD contains PIE_LDFLAGS while something_LDFLAGS
doesn't.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tools/Makefile.am | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/Makefile.am b/tools/Makefile.am
index d39f2ba..73cad50 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -185,11 +185,11 @@ virt_login_shell_SOURCES =					\
 
 virt_login_shell_LDFLAGS = \
 		$(AM_LDFLAGS) 					\
+		$(PIE_LDFLAGS)					\
 		$(COVERAGE_LDFLAGS)				\
 		$(NULL)
 virt_login_shell_LDADD =					\
 		$(STATIC_BINARIES)				\
-		$(PIE_LDFLAGS)					\
 		../src/libvirt-setuid-rpc-client.la		\
 		../gnulib/lib/libgnu.la
 
@@ -218,11 +218,11 @@ virsh_SOURCES =							\
 
 virsh_LDFLAGS = \
 		$(AM_LDFLAGS) 					\
+		$(PIE_LDFLAGS)					\
 		$(COVERAGE_LDFLAGS)				\
 		$(NULL)
 virsh_LDADD =							\
 		$(STATIC_BINARIES)				\
-		$(PIE_LDFLAGS)					\
 		../src/libvirt-lxc.la				\
 		../src/libvirt-qemu.la				\
 		libvirt_shell.la
-- 
2.4.10




More information about the libvir-list mailing list