[libvirt] [PATCH 3/4] virsh: Pass ctl to virshCatchDisconnect

Andrea Bolognani abologna at redhat.com
Mon Dec 21 14:00:42 UTC 2015


On Mon, 2015-12-21 at 11:04 +0100, Jiri Denemark wrote:
> virshCatchDisconnect expects ctl, but we were just passing NULL instead.
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  tools/virsh.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/virsh.c b/tools/virsh.c
> index 7484bed..2b53bf7 100644
> --- a/tools/virsh.c
> +++ b/tools/virsh.c
> @@ -207,7 +207,7 @@ virshReconnect(vshControl *ctl)
>              vshError(ctl, "%s", _("failed to connect to the hypervisor"));
>      } else {
>          if (virConnectRegisterCloseCallback(priv->conn, virshCatchDisconnect,
> -                                            NULL, NULL) < 0)
> +                                            ctl, NULL) < 0)
>              vshError(ctl, "%s", _("Unable to register disconnect callback"));
>          if (connected)
>              vshError(ctl, "%s", _("Reconnected to the hypervisor"));
> @@ -294,7 +294,7 @@ cmdConnect(vshControl *ctl, const vshCmd *cmd)
>      }
>  
>      if (virConnectRegisterCloseCallback(priv->conn, virshCatchDisconnect,
> -                                        NULL, NULL) < 0)
> +                                        ctl, NULL) < 0)
>          vshError(ctl, "%s", _("Unable to register disconnect callback"));
>  
>      return true;

ACK.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list