[libvirt] [PATCHv2] lxc: fix show the wrong xml when guest start failed

lhuang lhuang at redhat.com
Wed Feb 4 03:03:51 UTC 2015


On 02/03/2015 11:01 PM, John Ferlan wrote:
>
> On 01/12/2015 09:33 AM, Luyao Huang wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1176503
>>
>> When guest start failed, libvirt will keep the current vm->def,
>> this will make a issue that we cannot get a right xml after guest
>> start failed. And don't call the stop/release hook to do some
>> other clean work.
>>
>> Call virLXCProcessCleanup to help us clean the source and call
>> the hooks if start a vm failed.
>>
>> Signed-off-by: Luyao Huang <lhuang at redhat.com>
>> ---
>> v2: use virLXCProcessCleanup to free the source and call the hook.
>>
>>   src/lxc/lxc_process.c | 69 ++++++++++++++++++++++-----------------------------
>>   1 file changed, 29 insertions(+), 40 deletions(-)
>>
> There's been some changes to virLXCProcessStart since this was written -
> a revisit/rework is in order.

Yes, thanks a lot for your remind :)
> John
Luyao




More information about the libvir-list mailing list