[libvirt] [RFC PATCH v2 02/12] domain_conf: introduce cpu def helpers

[Daniel P. Berrange]

On Wed, Feb 04, 2015 at 05:42:42PM +0800, Zhu Guihua wrote:
> On Wed, 2015-02-04 at 09:25 +0000, Daniel P. Berrange wrote:
> > On Wed, Feb 04, 2015 at 05:18:20PM +0800, Zhu Guihua wrote:
> > > virDomainCPUDefFree - free memory allocated
> > > virDomainCPUDefParseXML - parse job type
> > > virDomainCPUDefFormat - output job type
> > > 
> > > Signed-off-by: Zhu Guihua <zhugh.fnst at cn.fujitsu.com>
> > > ---
> > >  docs/formatdomain.html.in     | 28 +++++++++++++++
> > >  docs/schemas/domaincommon.rng |  3 ++
> > >  src/conf/domain_conf.c        | 82 +++++++++++++++++++++++++++++++++++++++++++
> > >  src/conf/domain_conf.h        |  1 +
> > >  src/libvirt_private.syms      |  1 +
> > >  5 files changed, 115 insertions(+)
> > > 
> > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> > > index f8d5f89..10cbd29 100644
> > > --- a/docs/formatdomain.html.in
> > > +++ b/docs/formatdomain.html.in
> > > @@ -5830,6 +5830,34 @@ qemu-kvm -net nic,model=? /dev/null
> > >      </dd>
> > >    </dl>
> > >  
> > > +  <h4><a name="elementsCpu">CPU device</a></h4>
> > > +  <p>
> > > +    CPU device allows to be hot added to the guest.
> > > +    <span class="since">Since 1.2.12, QEMU and KVM only</span>
> > > +  </p>
> > > +
> > > +<pre>
> > > +  ...
> > > +  <devices>
> > > +    <cpu match='exact'>
> > > +      <model fallback='allow'>core2duo</model>
> > > +      <vendor>Intel</vendor>
> > > +      <topology sockets='1' cores='2' threads='1'/>
> > > +      <feature policy='disable' name='lahf_lm'/>
> > > +    </cpu>
> > > +  <devices>
> > 
> > NACK, it is just madness to duplicate the CPU info we already have
> > in a different place in the XML.
> 
> Yes, it's duplicate. But I think it represents different meaning, it is
> under xml tag 'device'.

Regardless my NACK stands. This kind of duplication is just madness
that causes problems for applications & developers alike.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|