[libvirt] [RFC PATCH 03/12] qemu: Implement setup of memory hotplug parameters
John Ferlan
jferlan at redhat.com
Wed Feb 4 22:08:07 UTC 2015
On 01/30/2015 08:21 AM, Peter Krempa wrote:
> To enable memory hotplug the maximum memory size and slot count need to
> be specified. As qemu supports now other units than mebibytes when
> specifying memory, use the new interface in this case.
> ---
> docs/formatdomain.html.in | 2 +-
> src/qemu/qemu_command.c | 41 ++++++++++++++++++----
> src/qemu/qemu_domain.c | 4 ---
> .../qemuxml2argv-memory-hotplug-nonuma.xml | 22 ++++++++++++
> .../qemuxml2argv-memory-hotplug.args | 6 ++++
> .../qemuxml2argv-memory-hotplug.xml | 34 ++++++++++++++++++
> tests/qemuxml2argvtest.c | 4 +++
> tests/qemuxml2xmltest.c | 3 ++
> 8 files changed, 105 insertions(+), 11 deletions(-)
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nonuma.xml
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug.args
> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug.xml
>
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 12f7ede..c059195 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -713,7 +713,7 @@
> Note that due to alignment of the memory chunks added via memory
> hotplug the full size allocation specified by this element may be
> impossible to achieve.
> - <span class='since'>Since 1.2.12</span>
> + <span class='since'>Since 1.2.12 supported by the QEMU driver.</span>
> </dd>
>
> <dt><code>currentMemory</code></dt>
My git am -3 wasn't happy with this change - didn't want to apply it:
fatal: sha1 information is lacking or useless (docs/formatdomain.html.in).
I just removed it and kept going...
John
More information about the libvir-list
mailing list