[libvirt] [PATCH v3] qemu: Pass file descriptor when using TPM passthrough

Stefan Berger stefanb at linux.vnet.ibm.com
Thu Feb 5 11:46:08 UTC 2015


On 01/30/2015 07:17 PM, Eric Blake wrote:
>> +        }
>> +        i++;
>> +    }
>> +
>> +    return -1;
>> +}
>> +
>>   /**
>>    * virCommandSetPidFile:
>>    * @cmd: the command to modify
>> diff --git a/src/util/vircommand.h b/src/util/vircommand.h
>> index bf65de4..198da2f 100644
>> --- a/src/util/vircommand.h
>> +++ b/src/util/vircommand.h
>> @@ -62,6 +62,9 @@ void virCommandPassFD(virCommandPtr cmd,
>>   
>>   void virCommandPassListenFDs(virCommandPtr cmd);
>>   
>> +int virCommandPassFDGetFDIndex(virCommandPtr cmd,
>> +                               int fd);
>> +
>>   void virCommandSetPidFile(virCommandPtr cmd,
>>                             const char *pidfile) ATTRIBUTE_NONNULL(2);
>>   
>>
> Overall, I can see what you are hoping to do, and it's my fault for
> taking this long to get back to you on it.  As penance, if you like my
> idea of changing virCommand to always remap child fds into consecutive
> orders, should I pitch in and help get that part of the patch in good
> condition?
>

Sounds good ;-) I'll get to the rest of your comments 'later'.

     Stefan




More information about the libvir-list mailing list