[libvirt] [RFC PATCH 07/12] qemu: migration: Forbid migration with memory modules lacking info

[Peter Krempa]

On Mon, Feb 09, 2015 at 10:24:04 +0000, Daniel Berrange wrote:
> On Fri, Jan 30, 2015 at 02:21:04PM +0100, Peter Krempa wrote:
> > Make sure that libvirt has all vital information needed to reliably
> > represent configuration of guest's memory devices in case of a
> > migration.
> > 
> > This patch forbids migration in case the required slot number and module
> > base address are not present (failed to be loaded from qemu via
> > monitor).
> 
> What would cause us to fail to load them from QEMU ? Is there a way we

Only a fatal monitor error or the command not being available would
prevent getting the info. I think it shouldn't ever be a problem for
anybody, but I wanted to be safe.

> can assign the address upfront like we do for other device types, so we
> can avoid the need to query QEMU & thus avoid failure scenario too ?

Qemu is aligning the memory regions to round numbers. I wanted to avoid
having to duplicate the logic used to do this in qemu and possibly have
to mirror it in cases it changes.

I don't really think users would gnerally care about the placement of
the module so the info is only required in case of miration.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150209/80a756be/attachment-0001.sig>