[libvirt] [PATCH 3/4] parallels: better bridge network interface support

[Michal Privoznik]

On 30.01.2015 20:58, Maxim Nestratov wrote:
> In order to support 'bridge' network adapters in parallels
> driver we need to plug our veth devices into corresponding
> linux bridges.
> We are going to do this by reusing our abstraction of
> Virtual Networks in terms of PCS. On a domain creation, we
> create a new Virtual Network naming it with the same name
> as a source bridge for each network  interface.
> Thus, we plug PCS veth interfaces created with names of
> target dev with specified bridges using our standard PCS
> procedures.
> 
> Signed-off-by: Maxim Nestratov <mnestratov at parallels.com>
> ---
>  src/parallels/parallels_sdk.c   |  112 ++++++++++++++++++++++++++++++++-------
>  src/parallels/parallels_utils.h |    1 +
>  2 files changed, 94 insertions(+), 19 deletions(-)

I'm seeing some syntax-check errors:

Curly brackets around single-line body:
src/parallels/parallels_sdk.c:747-749:
        if (!STREQ(net->data.network.name, PARALLELS_BRIDGED_NETWORK_NAME)) {
            net->type = VIR_DOMAIN_NET_TYPE_BRIDGE;
        }
No whitespace after keyword:
src/parallels/parallels_sdk.c:2628:         if(PRL_FAILED(pret = waitJob(job, privconn->jobTimeout)))
No whitespace after keyword:
src/parallels/parallels_sdk.c:2657:     if(net->type != VIR_DOMAIN_NET_TYPE_BRIDGE)
No whitespace after keyword:
src/parallels/parallels_sdk.c:2668:     if(PRL_FAILED(pret = waitJob(job, privconn->jobTimeout)))
Curly brackets around single-line body:
src/parallels/parallels_sdk.c:3060-3062:
    for (i = 0; i < dom->def->nnets; i++) {
       prlsdkDelNet(privconn, dom->def->nets[i]);
    }

Michal