[libvirt] [PATCH] qemu: fix setting of VM CPU affinity with TCG

[Daniel P. Berrange]

On Wed, Feb 11, 2015 at 10:00:36AM +0000, Daniel P. Berrange wrote:
> On Wed, Feb 11, 2015 at 10:18:43AM +0100, Ján Tomko wrote:
> > On Tue, Feb 10, 2015 at 04:25:51PM +0000, Daniel P. Berrange wrote:
> > > If a previous commit I fixed the incorrect handling of vcpu pids
> > > for TCG mode QEMU:
> > > 
> > 
> > ...
> > 
> > > 
> > > To fix this we must update qemuProcessSetVcpuAffinities so that it
> > > only reports a fatal error if the per-VCPU cpu mask is different
> > > from the VM level cpu mask.
> > > 
> > > Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> > > ---
> > >  src/qemu/qemu_process.c | 15 ++++++++++++---
> > >  1 file changed, 12 insertions(+), 3 deletions(-)
> > > 
> > 
> > ACK
> > 
> > virBitmapEqual works on NULL bitmaps since commit 20448c2, so the v2
> > is not needed.
> 
> Hmm, I got a crash of libvirtd before i added the NULL check. So I'll
> have to double check that again.

I guess I must have had a bad build, as it doesn't crash now and the
virBitmapEqual function clearly checks for NULL

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|