[libvirt] [PATCHv2] libxl: set IP address when creating NIC

Jim Fehlig jfehlig at suse.com
Thu Feb 12 15:57:38 UTC 2015


Jim Fehlig wrote:
> Jihoon Kim wrote:
>   
>> From: Ji-hoon Kim <relip at me.com>
>>
>> Currently libxlMakeNic() does not set ip address when creating NIC,
>> this patch makes it to set ip address.
>>   
>>     
>
> FYI, Marek recently sent a patch to do the same
>
> https://www.redhat.com/archives/libvir-list/2015-February/msg00139.html
>
> I like Marek's error checking for multiple IPs in
> libxlDomainDeviceDefPostParse(), but do think that <ip address=''>
> should also be supported for <interface type=network>.
>   

Marek provided a follow-up patch, which I've pushed

http://libvirt.org/git/?p=libvirt.git;a=commit;h=8703ee58bd9d9d02b5d64fae48c96f8940b9d0ff

Thanks again for helping with the libxl driver!  Any improvements or
fixes you have are welcomed.

Regards,
Jim




More information about the libvir-list mailing list