[libvirt] [PATCH 4/4] PowerPC : Do not allow floppy disks in domain XML.

Prerna Saxena prerna at linux.vnet.ibm.com
Sun Feb 15 04:32:25 UTC 2015


Subject: [PATCH 4/4] PowerPC : Do not allow floppy disks in domain XML.

PowerKVM does not support floppy disks. Ensure that libvirt honours this.
Fixes : https://bugzilla.redhat.com/show_bug.cgi?id=1180486

Signed-off-by: Prerna Saxena <prerna at linux.vnet.ibm.com>
---
 src/conf/domain_conf.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 6a57d80..df3a768 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -13892,6 +13892,14 @@ virDomainDefParseXML(xmlDocPtr xml,
         if (!disk)
             goto error;
 
+        if (ARCH_IS_PPC64(def->os.arch) &&
+            STREQLEN(def->os.machine, "pseries", 7) &&
+            disk->device == VIR_DOMAIN_DISK_DEVICE_FLOPPY) {
+                virReportError(VIR_ERR_INTERNAL_ERROR,
+                          _("Pseries machine does not support floppy device"));
+                goto error;
+        }
+
         virDomainDiskInsertPreAlloced(def, disk);
     }
     VIR_FREE(nodes);
-- 
1.9.3

-- 
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India




More information about the libvir-list mailing list