[libvirt] [PATCH] qemu: fix vm deadlock when try to use numatune in session mode

Pavel Hrdina phrdina at redhat.com
Tue Feb 17 10:11:16 UTC 2015


On Tue, Feb 17, 2015 at 11:37:52AM +0800, Luyao Huang wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1126762
> 
> commit 43b67f introduce a deadlock issue when we use numatune

s/commit/Commit/
s/introduce/introduced/

> to change numa settings to a vm in session mode.
> 
> Jump to endjob instead of jump to cleanup.
> 
> Signed-off-by: Luyao Huang <lhuang at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 709f468..1bbbe9b 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -9495,7 +9495,7 @@ qemuDomainSetNumaParameters(virDomainPtr dom,
>          flags & VIR_DOMAIN_AFFECT_LIVE) {
>          virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
>                         _("NUMA tuning is not available in session mode"));
> -        goto cleanup;
> +        goto endjob;
>      }
>  
>      if (flags & VIR_DOMAIN_AFFECT_LIVE) {
> -- 
> 1.8.3.1
> 

ACK and pushed.

Pavel

> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list




More information about the libvir-list mailing list