[libvirt] [PATCH 18/24] conf: numa: Don't pass double pointer to virDomainNumatuneParseXML

John Ferlan jferlan at redhat.com
Thu Feb 19 23:25:15 UTC 2015



On 02/16/2015 01:52 PM, Peter Krempa wrote:
> virDomainNumatuneParseXML now doesn't allocate the def->numa object any
> longer so we don't need to pass a double pointer.
> ---
>  src/conf/domain_conf.c |  2 +-
>  src/conf/numa_conf.c   | 23 +++++++++++------------
>  src/conf/numa_conf.h   |  2 +-
>  3 files changed, 13 insertions(+), 14 deletions(-)
> 

You could probably also just pass "def" to virDomainNumatuneParseXML and
let it handle the checking placement_mode and cpu rather than doing it
as part of the caller.


ACK to what's here though.

John




More information about the libvir-list mailing list