[libvirt] [PATCH] network: allow <pf> together with <interface>/<address> in network status

[Eric Blake]

On 02/19/2015 09:47 AM, Laine Stump wrote:
> The function that parses the <forward> subelement of a network used to
> fail/log an error if the network definition contained both a <pf>
> element as well as at least one <interface> or <address> element. That
> check was present because the configuration of a network should have
> either one <pf>, one or more <interface>, or one or more <address>,
> but never combinations of multiple kinds.
> 

> It appears that this problem has been in the code ever since support
> for <pf> was added (0.9.10), but until commit
> 34cc3b2f106e296df5e64309620c79d16fd76c85 (first in libvirt 1.2.4)
> networks with interface pools were not properly marked as active on
> restart anyway, so there is no point in backporting this patch any
> further than that.
> ---
>  src/conf/network_conf.c     | 10 +---------
>  src/network/bridge_driver.c | 35 +++++++++++++++++++++++++++++++++++
>  2 files changed, 36 insertions(+), 9 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150219/7d18a6cd/attachment-0001.sig>