[libvirt] [PATCH 02/24] conf: Move NUMA cell parsing code from cpu conf to numa conf

[Peter Krempa]

On Thu, Feb 19, 2015 at 16:12:28 -0500, John Ferlan wrote:
> 
> 
> On 02/16/2015 01:51 PM, Peter Krempa wrote:
> > For weird historical reasons NUMA cells are added as a subelement of
> > <cpu> while the actual configuration is done in <numatune>.
> > 
> > This patch splits out the cell parser code from cpu config to NUMA
> > config. Note that the changes to the code are minimal just to make it
> > work and the function will be refactored in the next patch.
> > ---
> >  src/conf/cpu_conf.c    |  90 ---------------------------------------
> >  src/conf/domain_conf.c |  17 +++++---
> >  src/conf/numa_conf.c   | 111 +++++++++++++++++++++++++++++++++++++++++++++++++
> >  src/conf/numa_conf.h   |   4 ++
> >  4 files changed, 126 insertions(+), 96 deletions(-)
> > 

...

> > +                VIR_FREE(memAccessStr);
> > +            }
> > +        }
> > +    }
> > +
> > +    ret = 0;
> > +
> > + error:
> > + cleanup:
> 
> Although this is mostly a cut'n'paste, why not just change the one "goto
> cleanup;" to goto error and then not have two labels?

I wanted to separate cleanup/refactor from the move :)

> 
> 
> ACK - since I'm sure you'll do the right thing...
> 
> John

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150220/bb98639b/attachment-0001.sig>