[libvirt] [PATCH 11/24] conf: numa: Refactor logic in virDomainNumatuneParseXML

[Peter Krempa]

On Thu, Feb 19, 2015 at 17:25:13 -0500, John Ferlan wrote:
> 
> 
> On 02/16/2015 01:51 PM, Peter Krempa wrote:
> > Shuffling around the logic will allow to simplify the code quite a bit.
> > As an additional bonus the change in the logic now reports an error if
> > automatic placement is selected and individual placement is configured.
> > ---
> >  src/conf/numa_conf.c | 53 +++++++++++++++++++++-------------------------------
> >  1 file changed, 21 insertions(+), 32 deletions(-)
> > 
> 
> hmm... perhaps one extra thing that could be done...
> 
> Now that the last/5th param to virDomainNumatuneSet isn't NULL for any
> caller (and the 4th isn't -1) - it looks like to me you can also modify
> numa_conf.h to add a ATTRIBUTE_NONNULL(5) for the function...

I'll do it separately as I don't fancy merge conflicts in a big series
:)
> 
> ACK

Thanks.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150220/c0bd1d15/attachment-0001.sig>