[libvirt] [PATCH 24/24] conf: Move all NUMA configuration to virDomainNuma
Peter Krempa
pkrempa at redhat.com
Fri Feb 20 17:01:05 UTC 2015
On Thu, Feb 19, 2015 at 19:28:56 -0500, John Ferlan wrote:
>
>
> On 02/16/2015 01:52 PM, Peter Krempa wrote:
> > For historical reasons data regarding NUMA configuration were split
> > between the CPU definition and numatune. We cannot do anything about the
> > XML still being split, but we certainly can at least store the relevant
> > data in one place.
> >
> > This patch moves the NUMA stuff to the right place.
> > ---
> > src/conf/cpu_conf.c | 26 +++----------------
> > src/conf/cpu_conf.h | 12 +++------
> > src/conf/domain_conf.c | 8 +++---
> > src/conf/numa_conf.c | 67 +++++++++++++++++++++++--------------------------
> > src/conf/numa_conf.h | 20 +++++++--------
> > src/cpu/cpu.c | 2 +-
> > src/qemu/qemu_command.c | 20 +++++++--------
> > tests/cputest.c | 2 +-
> > tests/testutilsqemu.c | 2 --
> > 9 files changed, 63 insertions(+), 96 deletions(-)
> >
>
> Ahh - the real magic comes in virDomainDefFormatInternal and
> virDomainNumaDefCPUParseXML.... Things see more logical now.
>
> ACK
I've fixed all the nits you've pointed out and pushed the series.
Thanks.
>
> John
Peter
>
> - ohhh -- running out of steam - brain cell crash
>
> - If someone doesn't get to them before me - I'll start on the 3 and 7
> patch series in the morning...
You definitely deserve some rest, thanks again.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150220/ac556ef3/attachment-0001.sig>
More information about the libvir-list
mailing list