[libvirt] [PATCH 06.1/10] xenconfig: add support for multiple USB devices syntax

[Marek Marczykowski-Górecki]

On Fri, Feb 20, 2015 at 04:10:47PM -0700, Jim Fehlig wrote:
> Marek Marczykowski-Górecki wrote:
> > In Xen>=4.3, libxl supports new syntax for USB devices:
> > usbdevice=[ "DEVICE", "DEVICE", ... ]
> > Add support for that in xenconfig driver. When only one device is
> > defined, keep using old syntax for backward compatibility.
> >   
> 
> Cool, thanks for doing this!  But I have a "small" nit...
> 
> > Signed-off-by: Marek Marczykowski-Górecki <marmarek at invisiblethingslab.com>
> > ---
> >  src/xenconfig/xen_common.c | 108 +++++++++++++++++++++++++++++++--------------
> >   
> 
> xm only supported the usbdevice=DEVICE syntax, but the code in
> xen_common is used to parse/format both xm and xl config.  I think
> parsing/formating of these devices should be moved to xen-xm and xen-xl.

Also multiple devices are supported only in Xen >= 4.3. I haven't seen
any constants for 4.x versions so haven't added new for that. Also names
(XEND_CONFIG_VERSION_*) and its place (xenconfig/xen_sxpr.h) suggests it
shouldn't be used for xl...

Should I add a new version somewhere there anyway?

I guess it applies also to other code there (which also doesn't bother
with different libxl versions), so I guess I can simply ignore this
issue.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150221/ca4ff258/attachment-0001.sig>