[libvirt] [PATCH] SRIOV NIC offload feature discovery

[Chapman, James P]

Thanks for your feedback folks, v2 to follow.


Thanks
James


-----Original Message-----
From: Daniel P. Berrange [mailto:berrange at redhat.com] 
Sent: Monday, February 16, 2015 11:47 AM
To: Chapman, James P
Cc: libvir-list at redhat.com
Subject: Re: [libvirt] [PATCH] SRIOV NIC offload feature discovery

On Mon, Feb 16, 2015 at 10:18:32AM +0000, James Chapman wrote:
> Adding functionality to libvirt that will allow it query the ethtool 
> interface for the availability of certain NIC HW offload features
> ---
>  src/conf/device_conf.h             |   6 ++
>  src/conf/node_device_conf.c        |   7 ++
>  src/conf/node_device_conf.h        |   2 +
>  src/libvirt_private.syms           |   1 +
>  src/node_device/node_device_udev.c |   4 ++
>  src/util/virnetdev.c               | 134 +++++++++++++++++++++++++++++++++++++
>  src/util/virnetdev.h               |  12 +++-
>  7 files changed, 165 insertions(+), 1 deletion(-)

If you're modifying the XML parser then you need to also change the XML schema (docs/schemas/nodedev.rng), add example XML for testing the schema (tests/nodedevschemadata) and finally extend the docs (docs/formatnodedev.html.in). Also it is good to include the proposed XML change in the commit message for reviewers.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|