[libvirt] [PATCH] qemu: fix memory leak while starting a guest

Peter Krempa pkrempa at redhat.com
Tue Feb 24 14:56:18 UTC 2015


On Tue, Feb 24, 2015 at 15:00:49 +0100, Pavel Hrdina wrote:
> In commit cc41c648 I've re-factored qemuMonitorFindBalloonObjectPath, but
> missed that there is a memory leak. The "nextpath" variable is
> overridden while looping in for cycle and we have to free it before next

overwritten

> cycle.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/qemu/qemu_monitor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
> index 6882a50..94495cd 100644
> --- a/src/qemu/qemu_monitor.c
> +++ b/src/qemu/qemu_monitor.c
> @@ -1067,6 +1067,7 @@ qemuMonitorFindObjectPath(qemuMonitorPtr mon,
>              }
>  
>              ret = qemuMonitorFindObjectPath(mon, nextpath, name, path);
> +            VIR_FREE(nextpath);
>          }
>      }
>  

ACK for 1.2.13,

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150224/8778e3e6/attachment-0001.sig>


More information about the libvir-list mailing list