[libvirt] [PATCH 0/2] check for null ifname when setting/clearing bandwidth

Martin Kletzander mkletzan at redhat.com
Wed Feb 25 09:40:25 UTC 2015


On Tue, Feb 24, 2015 at 02:39:52PM -0500, Laine Stump wrote:
>When John Ferlan ran the Coverity static checker on my patches to fix
>the problem with nicindexes, it began complaining about calling the
>virNetDevBandwidth* functions with a null ifname. Investigation
>pointed out some real problems with this that are fixed by these two
>patches (which will be pushed *before* the nicindex fix patch).
>

Makes sense and works for me, ACK series after release.

>
>Laine Stump (2):
>  network: only clear bandwidth if it has been set
>  util: check for null ifname inside virNetDevBandwidthSet()
>
> src/conf/netdev_bandwidth_conf.c | 6 ++++--
> src/lxc/lxc_driver.c             | 7 ++++++-
> src/network/bridge_driver.c      | 6 ++++--
> src/qemu/qemu_hotplug.c          | 4 +++-
> src/util/virnetdevbandwidth.c    | 9 ++++++++-
> src/util/virnetdevbandwidth.h    | 4 ++--
> 6 files changed, 27 insertions(+), 9 deletions(-)
>
>--
>2.1.0
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150225/9c5e8e3a/attachment-0001.sig>


More information about the libvir-list mailing list