[libvirt] [PATCH for 1.2.13] schema: Add virtio-mmio address type into RNG
Daniel P. Berrange
berrange at redhat.com
Wed Feb 25 10:34:52 UTC 2015
On Wed, Feb 25, 2015 at 11:30:51AM +0100, Martin Kletzander wrote:
> The "virtio-mmio" is perfectly valid address type which we parse and
> format correctly, but it's missing in our RNG schemas, hence editing a
> domain with device having such address fails the validation.
>
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
> docs/schemas/domaincommon.rng | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index f41ca43..6e73e7c 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -4415,6 +4415,11 @@
> </attribute>
> <ref name="isaaddress"/>
> </group>
> + <group>
> + <attribute name="type">
> + <value>virtio-mmio</value>
> + </attribute>
> + </group>
> </choice>
> </element>
> </define>
ACK, but this suggests our qemuxml2argdata/ directory doesn't have
any coverage of the mmio addressing scheme, as we would have got
RNG failures if it did.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list