[libvirt] [PATCH] maint: update to latest gnulib

[Eric Blake]

On 02/25/2015 12:20 AM, Martin Kletzander wrote:
> On Tue, Feb 24, 2015 at 09:04:00AM -0700, Eric Blake wrote:
>> On 02/24/2015 09:00 AM, Eric Blake wrote:
>>> Needed to silence a valgrind detection of uninitialized memory:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1174147
>>>
>>> * .gnulib: Update to latest.
>>> * bootstrap: Resync to gnulib.
>>>
>>> Signed-off-by: Eric Blake <eblake at redhat.com>
>>> ---
>>>
>>> I've missed RC1, so I'll wait for a review on this one (are we sure
>>> that RC2 will be enough time to ensure the gnulib update doesn't
>>> cause regressions, basically).
>>
> 
> Is it worth risking that due to one valgrind warning?  I don't
> remember more than maybe one time that gnulib caused a problem, but
> who knows.

And the valgrind warning is harmless - it's complaining about passing
uninitialized memory to a syscall, but that memory lives in the padding
of a struct, and none of the code is actually acting on that memory
(either on our side, or in the syscall).  If we want to just live with
the warning until after the release, that would also be okay - we have
up until the RC2 date to make the decision.

> 
> Anyway, "my limited testing" didn't show any problems.
> 
>> The gnulib changelog:

Most of the changes here are for Android, but I don't know of anyone
building libvirt on that platform yet.  That said,...

>>
>> * .gnulib c27f1a3...8be5f2c (75):
>>  > passfd: avoid valgrind uninitalised data warning

This one fixes the valgrind warning...

>>  > gnulib-tool: fix handling of patch(1) diagnostics
>>  > bootstrap: exit immediately upon gnulib-tool failure

these two are useful to us as developers, but don't affect the code base...

>>  > count-leading-zeros: use 64-bit intrinsics on 32-bit Windows
>>  > count-leading-zeros: fix pragma typos

and these might affect mingw builds.

Any other opinions?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150225/0b8ef840/attachment-0001.sig>