[libvirt] [PATCH] Fix typos in messages

[Ján Tomko]

On Fri, Feb 20, 2015 at 07:21:08PM +0100, Pavel Hrdina wrote:
> On Fri, Feb 20, 2015 at 06:50:40PM +0200, Yuri Chornoivan wrote:
> > ---
> >   src/parallels/parallels_sdk.c |  2 +-
> >   src/qemu/qemu_monitor_json.c  | 10 +++++-----
> >   2 files changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c
> > index bbc26ef..36c6c5f 100644
> > --- a/src/parallels/parallels_sdk.c
> > +++ b/src/parallels/parallels_sdk.c
> > @@ -2307,7 +2307,7 @@ static int  
> > prlsdkCheckDiskUnsupportedParams(virDomainDiskDefPtr disk)
> > 
> >           virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> >                          _("Only hard disks and cdroms are supported "
> > -                         "supported by parallels driver."));
> > +                         "by parallels driver."));
> >           return -1;
> >       }
> > 
> 
> It will be better to split the patch into two commits, because it's not the same
> typo.
> 

Historically, we've done patches cleaning up typos across the codebase
in a single commit. I think it's fine as is.

> > diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> > index da5c14d..832f589 100644
> > --- a/src/qemu/qemu_monitor_json.c
> > +++ b/src/qemu/qemu_monitor_json.c
> > @@ -1320,7 +1320,7 @@ qemuMonitorJSONUpdateVideoMemorySize(qemuMonitorPtr  
> > mon,
> >       case VIR_DOMAIN_VIDEO_TYPE_VGA:
> >           if (qemuMonitorJSONGetObjectProperty(mon, path, "vgamem_mb",  
> > &prop) < 0) {
> >               virReportError(VIR_ERR_INTERNAL_ERROR,
> > -                           _("QOM Objext '%s' has no property  
> > 'vgamem_mb'"),
> > +                           _("QOM Object '%s' has no property  
> > 'vgamem_mb'"),
> >                              path);
> >               return -1;
> >           }
> > @@ -1329,21 +1329,21 @@  
> > qemuMonitorJSONUpdateVideoMemorySize(qemuMonitorPtr mon,
> >       case VIR_DOMAIN_VIDEO_TYPE_QXL:
> >           if (qemuMonitorJSONGetObjectProperty(mon, path, "vram_size",  
> > &prop) < 0) {
> >               virReportError(VIR_ERR_INTERNAL_ERROR,
> > -                           _("QOM Objext '%s' has no property  
> > 'vram_size'"),
> > +                           _("QOM Object '%s' has no property  
> > 'vram_size'"),
> >                              path);
> >               return -1;
> >           }
> >           video->vram = prop.val.ul / 1024;
> >           if (qemuMonitorJSONGetObjectProperty(mon, path, "ram_size",  
> > &prop) < 0) {
> >               virReportError(VIR_ERR_INTERNAL_ERROR,
> > -                           _("QOM Objext '%s' has no property  
> > 'ram_size'"),
> > +                           _("QOM Object '%s' has no property  
> > 'ram_size'"),
> >                              path);
> >               return -1;
> >           }
> >           video->ram = prop.val.ul / 1024;
> >           if (qemuMonitorJSONGetObjectProperty(mon, path, "vgamem_mb",  
> > &prop) < 0) {
> >               virReportError(VIR_ERR_INTERNAL_ERROR,
> > -                           _("QOM Objext '%s' has no property  
> > 'vgamem_mb'"),
> > +                           _("QOM Object '%s' has no property  
> > 'vgamem_mb'"),
> >                              path);
> >               return -1;
> >           }
> > @@ -1352,7 +1352,7 @@ qemuMonitorJSONUpdateVideoMemorySize(qemuMonitorPtr  
> > mon,
> >       case VIR_DOMAIN_VIDEO_TYPE_VMVGA:
> >           if (qemuMonitorJSONGetObjectProperty(mon, path, "vgamem_mb",  
> > &prop) < 0) {
> >               virReportError(VIR_ERR_INTERNAL_ERROR,
> > -                           _("QOM Objext '%s' has no property  
> > 'vgamem_mb'"),
> > +                           _("QOM Object '%s' has no property  
> > 'vgamem_mb'"),
> >                              path);
> >               return -1;

Hmm, I wonder why we need to repeat the same error message five times.

> >           }
> > -- 
> > 1.8.5.6
> 
> Please use "git send-email" to send patches to mailing list because usually mail
> clients tends to format the message and when it happens it's not possible
> cleanly apply that patches using "git am".

I have fixed the mangled patch and pushed it.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150225/9c3a28ca/attachment-0001.sig>