[libvirt] [PATCH 1/3] iface-define: update and unify documentation

Pavel Hrdina phrdina at redhat.com
Wed Feb 25 15:40:46 UTC 2015


Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1127045

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 src/libvirt-interface.c | 3 ++-
 tools/virsh-interface.c | 5 +++--
 tools/virsh.pod         | 4 ++--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/libvirt-interface.c b/src/libvirt-interface.c
index 815a41a..4bdb3a8 100644
--- a/src/libvirt-interface.c
+++ b/src/libvirt-interface.c
@@ -443,7 +443,8 @@ virInterfaceGetXMLDesc(virInterfacePtr iface, unsigned int flags)
  * @xml: the XML description for the interface, preferably in UTF-8
  * @flags: extra flags; not used yet, so callers should always pass 0
  *
- * Define an interface (or modify existing interface configuration).
+ * Define an inactive persistent physical host interface or modify an existing
+ * persistent one from the XML description.
  *
  * Normally this change in the interface configuration is immediately
  * permanent/persistent, but if virInterfaceChangeBegin() has been
diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c
index 5f848b6..57966b5 100644
--- a/tools/virsh-interface.c
+++ b/tools/virsh-interface.c
@@ -507,10 +507,11 @@ cmdInterfaceDumpXML(vshControl *ctl, const vshCmd *cmd)
  */
 static const vshCmdInfo info_interface_define[] = {
     {.name = "help",
-     .data = N_("define (but don't start) a physical host interface from an XML file")
+     .data = N_("define an inactive persistent physical host interface or "
+                "modify an existing persistent one from an XML file")
     },
     {.name = "desc",
-     .data = N_("Define a physical host interface.")
+     .data = N_("Define or modify a persistent physical host interface.")
     },
     {.name = NULL}
 };
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 343f26f..6e65dfb 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -2835,8 +2835,8 @@ See also B<iface-unbridge> for undoing this operation.
 
 =item B<iface-define> I<file>
 
-Define a host interface from an XML I<file>, the interface is just defined but
-not started.
+Define an inactive persistent physical host interface or modify an existing
+persistent one from the XML I<file>.
 
 =item B<iface-destroy> I<interface>
 
-- 
2.0.5




More information about the libvir-list mailing list