[libvirt] [PATCH 2/3] pool-define: update and unify documentation

Pavel Hrdina phrdina at redhat.com
Wed Feb 25 15:40:47 UTC 2015


Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1127045

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
---
 src/libvirt-storage.c | 4 ++--
 tools/virsh-pool.c    | 5 +++--
 tools/virsh.pod       | 3 ++-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c
index 54c7332..704597d 100644
--- a/src/libvirt-storage.c
+++ b/src/libvirt-storage.c
@@ -551,8 +551,8 @@ virStoragePoolCreateXML(virConnectPtr conn,
  * @xml: XML description for new pool
  * @flags: extra flags; not used yet, so callers should always pass 0
  *
- * Define a new inactive storage pool based on its XML description. The
- * pool is persistent, until explicitly undefined.
+ * Define an inactive persistent storage pool or modify an existing persistent
+ * one from the XML description.
  *
  * virStoragePoolFree should be used to free the resources after the
  * storage pool object is no longer needed.
diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
index addbccc..f93a0bc 100644
--- a/tools/virsh-pool.c
+++ b/tools/virsh-pool.c
@@ -397,10 +397,11 @@ cmdPoolCreateAs(vshControl *ctl, const vshCmd *cmd)
  */
 static const vshCmdInfo info_pool_define[] = {
     {.name = "help",
-     .data = N_("define (but don't start) a pool from an XML file")
+     .data = N_("define an inactive persistent storage pool or modify "
+                "an existing persistent one from an XML file")
     },
     {.name = "desc",
-     .data = N_("Define a pool.")
+     .data = N_("Define or modify a persistent storage pool.")
     },
     {.name = NULL}
 };
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 6e65dfb..780f75b 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -3030,7 +3030,8 @@ the vHBA.
 
 =item B<pool-define> I<file>
 
-Create, but do not start, a pool object from the XML I<file>.
+Define an inactive persistent storage pool or modify an existing persistent one
+from the XML I<file>.
 
 =item B<pool-define-as> I<name> I<type> [I<--print-xml>]
 [I<--source-host hostname>] [I<--source-path path>] [I<--source-dev path>]
-- 
2.0.5




More information about the libvir-list mailing list