[libvirt] [PATCH] conf: error out on missing dhcp host attributes

Ján Tomko jtomko at redhat.com
Thu Feb 26 08:10:12 UTC 2015


In virNetworkDHCPHostDefParseXML an error is reported
when partialOkay == true, and none of ip, mac, name
were supplied.

Add the missing goto and error out in this case.
---
 src/conf/network_conf.c | 1 +
 1 file changed, 1 insertion(+)

Pushed as trivial.

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index 52fcf3d..0f4fc1e 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -746,6 +746,7 @@ virNetworkDHCPHostDefParseXML(const char *networkName,
                              "must be specified for static host definition "
                              "in network '%s' "),
                            networkName);
+            goto cleanup;
         }
     } else {
         /* normal usage - you need at least name (IPv6) or one of MAC
-- 
2.0.5




More information about the libvir-list mailing list