[libvirt] [PATCHv2 4/7] phyp: Fix error messages mentioning memory

Martin Kletzander mkletzan at redhat.com
Thu Feb 26 12:29:15 UTC 2015


On Wed, Feb 25, 2015 at 11:22:03AM +0100, Peter Krempa wrote:
>The messages for currentMemory and memory were swapped.
>---
>
>Notes:
>    Version 2:
>    - new in series
>
> src/phyp/phyp_driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c
>index c1d6eb2..a1e390d 100644
>--- a/src/phyp/phyp_driver.c
>+++ b/src/phyp/phyp_driver.c
>@@ -3488,14 +3488,14 @@ phypBuildLpar(virConnectPtr conn, virDomainDefPtr def)
>
>     if (!def->mem.cur_balloon) {
>         virReportError(VIR_ERR_XML_ERROR, "%s",
>-                       _("Field <memory> on the domain XML file is missing or has "
>+                       _("Field <currentMemory> on the domain XML file is missing or has "
>                          "invalid value."));

You could've wrapped the message to fit into 80 columns and remove the
dot at the and as well.  ACK with that changed.

>         goto cleanup;
>     }
>
>     if (!virDomainDefGetMemoryInitial(def)) {
>         virReportError(VIR_ERR_XML_ERROR, "%s",
>-                       _("Field <currentMemory> on the domain XML file is missing or "
>+                       _("Field <memory> on the domain XML file is missing or "

ditto

>                          "has invalid value."));
>         goto cleanup;
>     }
>--
>2.2.2
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150226/d1004240/attachment-0001.sig>


More information about the libvir-list mailing list