[libvirt] [PATCH v1 06/31] virNetworkObjListFree: Accept NULL

Peter Krempa pkrempa at redhat.com
Thu Feb 26 15:04:41 UTC 2015


On Thu, Feb 26, 2015 at 15:17:15 +0100, Michal Privoznik wrote:
> All of our vir*Free() functions should accept NULL, even though
> that there's no way of actually passing NULL with current code.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/conf/network_conf.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
> index 154a9bc..9734a7f 100644
> --- a/src/conf/network_conf.c
> +++ b/src/conf/network_conf.c
> @@ -279,6 +279,9 @@ void virNetworkObjListFree(virNetworkObjListPtr nets)
>  {
>      size_t i;
>  
> +    if (!nets)
> +        return;
> +
>      for (i = 0; i < nets->count; i++)
>          virNetworkObjFree(nets->objs[i]);

Since the function does not free @nets at the end it should really be
called virNetworkObjListClear. But that was present previously too.

ACK as is.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150226/939489af/attachment-0001.sig>


More information about the libvir-list mailing list