[libvirt] [PATCH] Ignore listen attribute of <graphics> for type network listens

[Ján Tomko]

On Thu, Feb 26, 2015 at 11:10:06AM -0500, Francesco Romani wrote:
> ----- Original Message -----
> > From: "Laine Stump" <laine at laine.org>
> > To: libvir-list at redhat.com
> > Cc: "Francesco Romani" <fromani at redhat.com>, "Ján Tomko" <jtomko at redhat.com>
> > Sent: Thursday, February 26, 2015 4:28:13 PM
> > Subject: Re: [libvirt] [PATCH] Ignore listen attribute of <graphics> for type network listens
> > 
> > On 02/26/2015 10:11 AM, Francesco Romani wrote:
> > > Hi,
> 
> [...]
> > > When we connect to display through oVirt, before to fire up we set up the
> > > password through virDomainUpdateDeviceFlags. This fails for me on libvirt
> > > 1.2.13
> > > from master with Commit 6992994
> > >
> > > Let me summarize the flow:
> > >
> > > we create and feed createXML with:
> > >
> > >                 <graphics autoport="yes" keymap="en-us" passwd="*****"
> > >                 passwdValidTo="1970-01-01T00:00:01" port="-1" tlsPort="-1"
> > >                 type="spice">
> > >                         <channel mode="secure" name="main"/>
> > >                         <channel mode="secure" name="inputs"/>
> > >                         <channel mode="secure" name="cursor"/>
> > >                         <channel mode="secure" name="playback"/>
> > >                         <channel mode="secure" name="record"/>
> > >                         <channel mode="secure" name="display"/>
> > >                         <channel mode="secure" name="usbredir"/>
> > >                         <channel mode="secure" name="smartcard"/>
> > >                         <listen network="vdsm-ovirtmgmt" type="network"/>
> > >                 </graphics>
> > >
> > > we get back using domainGetXmlDesc:
> > 
> > This is where the error is caused - you need to add the inactive flag to
> > this call
> 
> Sorry, I forgot to point out that oVirt uses transient domains, so to use the
> inactive flag is surprising to me. I'm not sure that will work for us.
> I need to check the docs and play with it for a bit.

The VIR_DOMAIN_XML_INACTIVE flag behaves differently for
persistent and transient domains.

In both cases, only the attributes that make sense in an inactive
domain definition are formatted. But for persistent domain, we format
the persistent definition, not the live definition, so hotplugged
devices will not appear there.

For transient domains, the live definition is formatted, just not with
all the attributes.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150226/15fb96f8/attachment-0001.sig>