[libvirt] [PATCH] Really fix XML formatting flags in SaveImageUpdateDef

[Pavel Hrdina]

On Fri, Feb 27, 2015 at 12:07:40PM +0100, Ján Tomko wrote:
> Commit cf2d4c6 used a logical or instead of bitwise or,
> effectively passing 1, that is VIR_DOMAIN_XML_INACTIVE.
> Yep, that's right.
> 
> This was caught by a warning when building with clang.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1183869
> ---
>  src/qemu/qemu_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index e9aa0b5..e282464 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -5734,7 +5734,7 @@ qemuDomainSaveImageUpdateDef(virQEMUDriverPtr driver,
>  
>      if (!(newdef_migr = qemuDomainDefCopy(driver,
>                                            newdef,
> -                                          QEMU_DOMAIN_FORMAT_LIVE_FLAGS ||
> +                                          QEMU_DOMAIN_FORMAT_LIVE_FLAGS |
>                                            VIR_DOMAIN_XML_MIGRATABLE)))
>          goto cleanup;
>  
> -- 
> 2.0.5
> 

ACK and safe for release.

Pavel

> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list