[libvirt] [PATCH] qemu: don't refuse to undefine a guest with NVRAM file

[Kashyap Chamarthy]

[/me still reading the complete discussion.]

On Tue, Feb 24, 2015 at 04:07:02PM +0100, Peter Krempa wrote:

[. . .]

> We have prior art in denying to undefine a domain that has information
> stored in libvirt-internal locations such as the managed save image and
> snapshot metadata.
> 
> While it makes sense to allow removing the VM without deleting the NVRAM
> file when the user specified an external path, we should avoid doing so
> if the NVRAM is in the libvirt managed path. (Same with externaly
> managed snapshots or save images).

I see, that explains, as I noticed it[*] when I placed the 'nvram' file
in /var/lib/libvirt/

    $ virsh dumpxml node2 | grep -i nvram  -A2 -B3
      <os>
        <type arch='aarch64' machine='virt'>hvm</type>
        <loader readonly='yes' type='pflash'>/usr/share/AAVMF/AAVMF_CODE.fd</loader>
        <nvram>/var/lib/libvirt/nvram/fedora-21-aarch64-nvram</nvram>
        <boot dev='hd'/>
      </os>


[*] https://bugzilla.redhat.com/show_bug.cgi?id=1195667 --
    libvirt fails to undefine a guest with `nvram` XML element


-- 
/kashyap