[libvirt] [PATCH] Makefile: Fix parallel build after Xen-xl parser introduction

Daniel P. Berrange berrange at redhat.com
Mon Jan 5 17:24:33 UTC 2015

On Mon, Jan 05, 2015 at 03:03:51PM +0100, Michal Privoznik wrote:
> Well, the parallel build doesn't work as there are not dependencies
> set correctly. When running 'make -j' I see this error:
> make[2]: Entering directory '/home/zippy/work/libvirt/libvirt.git/src'
>   GEN      util/virkeymaps.h
>   GEN      locking/lock_protocol.h
> make[2]: *** No rule to make target 'xenconfig/xen_xl_disk.h', needed by 'all'.  Stop.
> make[2]: *** Waiting for unfinished jobs....
>   GEN      lxc/lxc_controller_dispatch.h
> The fix is to correctly set dependencies by letting make know that .c
> and .h are to be generated from .l. Moreover, the section is moved
> closer to the other section which uses it.
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> I'm not fully satisfied with this patch yet. I mean, for some
> reason it creates 'src/.h' file, but hey - it makes parallel
> build work again. Any brighter idea appreciated.


> +AM_LFLAGS = -Pxl_disk_ --header-file=../$*.h

I'm not convinced that '$*' is valid here - it probably expands to
the empty string which could explain your mysterious 'src/.h' file

|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

More information about the libvir-list mailing list