[libvirt] [PATCH] networkGetDHCPLeases: Remove unnecessary error reporting

Eric Blake eblake at redhat.com
Tue Jan 6 00:01:09 UTC 2015


On 01/05/2015 12:16 PM, John Ferlan wrote:
> 
> 
> On 01/05/2015 12:49 PM, Nehal J Wani wrote:
>> Lack of a lease (whether mac is given or not) is a normal expected scenario.
>> There is no need to raise an error.
>>
>> Signed-off-by: Nehal J Wani <nehaljw.kkd1 at gmail.com>
>> ---
>>  src/network/bridge_driver.c | 6 ------
>>  1 file changed, 6 deletions(-)
>>
> 
> 
> Since it was introduced by your own commit id 'ba5139821' and a recent
> query here had Dan's blessing:
> 
> http://www.redhat.com/archives/libvir-list/2015-January/msg00055.html
> 
> 
> ACK - although perhaps it would be nice to put the information from the
> above linked query in the commit message in order to at least provide a
> bit more context as to why it's being removed.  I'd say cut-n-paste the
> text after "In my opinion...".

I tweaked the commit message and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150105/cf862207/attachment-0001.sig>


More information about the libvir-list mailing list