[libvirt] [PATCH] qemu: Fix system pages handling in <memoryBacking/>

Martin Kletzander mkletzan at redhat.com
Wed Jan 7 15:28:48 UTC 2015

On Wed, Jan 07, 2015 at 03:23:19PM +0100, Michal Privoznik wrote:
>In one of my previous commits (311b4a67) I've tried to allow to pass
>regular system pages to <hugepages>. However, there was a little bug
>that wasn't caught. If domain has guest NUMA topology defined,
>qemuBuildNumaArgStr() function takes care of generating corresponding
>command line. The hugepages backing for guest NUMA nodes is handled
>there too. And here comes the bug: the hugepages setting from XML is
>stored in KiB internally, however, the system pages size was queried
>and stored in Bytes. So the check whether these two equal was failing

s/two equal/two are equal/

I can't think of a system with page size non-divisible by 1024, so ACK.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150107/3b7e5232/attachment-0001.sig>

More information about the libvir-list mailing list