[libvirt] [PATCH v4 2/2] src/Makefile: Fix parallel build after xen_xl_disk parser introduction
phrdina at redhat.com
Thu Jan 8 13:46:46 UTC 2015
On 01/08/2015 02:31 PM, Daniel P. Berrange wrote:
> On Thu, Jan 08, 2015 at 02:20:25PM +0100, Pavel Hrdina wrote:
>> Well, the parallel build doesn't work as there are not dependencies
>> set correctly. When running 'make -j' I see this error:
>> make: Entering directory '/home/zippy/work/libvirt/libvirt.git/src'
>> GEN util/virkeymaps.h
>> GEN locking/lock_protocol.h
>> make: *** No rule to make target 'xenconfig/xen_xl_disk.h', needed by 'all'. Stop.
>> make: *** Waiting for unfinished jobs....
>> GEN lxc/lxc_controller_dispatch.h
>> The fix is to correctly set dependencies by letting make know that .c
>> and .h are to be generated from .l. Moreover, the section is moved
>> closer to the other section which uses it.
> The second sentance can be removed, since the movement is in the
> previous patch now.
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>> src/Makefile.am | 21 ++++++++++++++++-----
>> 1 file changed, 16 insertions(+), 5 deletions(-)
> ACK assuming you tested both VPATH & non-VPATH builds.
Yes I've tested both builds, thanks for review.
More information about the libvir-list