[libvirt] [python PATCH] build: make it easier to backport event ids

Eric Blake eblake at redhat.com
Thu Jan 15 17:01:59 UTC 2015

On 01/15/2015 09:06 AM, Daniel P. Berrange wrote:
> On Thu, Jan 15, 2015 at 08:52:44AM -0700, Eric Blake wrote:
>> On 01/15/2015 03:51 AM, Jiri Denemark wrote:
>>> On Thu, Jan 15, 2015 at 10:42:39 +0000, Daniel Berrange wrote:
>>>> On Wed, Jan 14, 2015 at 08:08:16PM -0700, Eric Blake wrote:
>>>>> In some cases, it is very easy for downstream distros to backport
>>>>> enum values without requiring a .so bump.  Keying the conditional
>>>>> code off of the upstream version where the enum value was added
>>>>> is not ideal, because downstream then has to patch that the feature
>>>>> is available in their build that still reports an earlier version
>>>>> number.  For example, if RHEL 7 backports events from 1.2.11 into
>>>>> a build based on 1.2.8, building the python bindings would warn:

> Sigh. In a sane world we would just fix the CPP to honour enums
> directly ;-P

Yeah, the fact that the preprocessor and compiler are historically
separate entities is baggage that we are stuck with.

>> So does this count as an ACK with the long line fixed?
> Sure, ACK

Thanks; pushed.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20150115/61069b5f/attachment-0001.sig>

More information about the libvir-list mailing list