[libvirt] [RFC PATCH 11/12] qemu_monitor_json: sort JSON array of cpu info

Zhu Guihua zhugh.fnst at cn.fujitsu.com
Thu Jan 22 08:52:23 UTC 2015


On Wed, 2015-01-21 at 10:34 +0100, Peter Krempa wrote:
> On Wed, Jan 21, 2015 at 16:01:03 +0800, Zhu Guihua wrote:
> > JSON array of cpu info is sorted in order to find thread id of cpu smoothly.
> > 
> > Signed-off-by: Zhu Guihua <zhugh.fnst at cn.fujitsu.com>
> > ---
> >  src/libvirt_private.syms     |  1 +
> >  src/qemu/qemu_monitor_json.c | 31 +++++++++++++++++++++++++++++--
> >  src/util/virbitmap.c         |  2 +-
> >  src/util/virbitmap.h         |  2 ++
> >  4 files changed, 33 insertions(+), 3 deletions(-)
> > 
> > diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> > index 032e9a9..d2c7c73 100644
> > --- a/src/libvirt_private.syms
> > +++ b/src/libvirt_private.syms
> > @@ -1042,6 +1042,7 @@ virBitmapFree;
> >  virBitmapGetBit;
> >  virBitmapIsAllClear;
> >  virBitmapIsAllSet;
> > +virBitmapIsSet;
> 
> This function is not used anywhere in this patch. Is this (and the other
> related hunks) here by accident?

It is an accident, it should be in another patch.

Thanks,
Zhu

> 
> >  virBitmapLastSetBit;
> >  virBitmapNew;
> >  virBitmapNewCopy;
> 
> Peter
> 





More information about the libvir-list mailing list