[libvirt] [PATCH] [Build-breaker : 1.2.12] Suppress compilation without dbus headers
Daniel P. Berrange
berrange at redhat.com
Mon Jan 26 09:17:07 UTC 2015
On Sun, Jan 25, 2015 at 05:56:25PM +0530, Prerna Saxena wrote:
> Hi,
> While testing 1.2.12 rc2 on Powerpc, Fedora 21, I hit a bunch of build failures in absence of dbus-devel :
>
> src/util/virsystemd.c:284:17: note: in expansion of macro 'STREQ_NULLABLE'
> if (STREQ_NULLABLE("org.freedesktop.DBus.Error.UnknownMethod",
> ^
> ....
> src/util/virsystemd.c:288:17: error: implicit declaration of function 'dbus_error_free' [-Werror=implicit-function-declaration]
> dbus_error_free(&error);
>
>
> Found that this was because commit 318df5a05 needs Dbus libraries for compilation, and configure didnt mark "with_dbus" to be mandatory. In this case, the compilation itself failed in a much uglier
> fashion on my system where dbus-devel was absent.
>
> The following patch introduces a compile error when dbus-devel is absent, so that the build itself proceeds later without cryptic errors.
>
> This has also been reported on the list : https://www.redhat.com/archives/libvir-list/2015-January/msg00641.html
I've already posted a fix for this problem
https://www.redhat.com/archives/libvir-list/2015-January/msg00869.html
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list