[libvirt] [PATCH] Remove flag checking in MacVLanCreate helper stub

Ján Tomko jtomko at redhat.com
Thu Jan 29 09:07:12 UTC 2015

When compiling without WITH_MACVTAP, we can get:
'unsupported flags (0x1) in function
on an attempt to start a domain.

Remove the flag check to reach the more helpful error:
Cannot create macvlan devices on this platform

 src/util/virnetdevmacvlan.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c
index f2eae06..6a8a923 100644
--- a/src/util/virnetdevmacvlan.c
+++ b/src/util/virnetdevmacvlan.c
@@ -1066,9 +1066,8 @@ int virNetDevMacVLanCreateWithVPortProfile(const char *ifname ATTRIBUTE_UNUSED,
                                            char **res_ifname ATTRIBUTE_UNUSED,
                                            virNetDevVPortProfileOp vmop ATTRIBUTE_UNUSED,
                                            char *stateDir ATTRIBUTE_UNUSED,
-                                           unsigned int flags)
+                                           unsigned int flags ATTRIBUTE_UNUSED)
-    virCheckFlags(0, -1);
     virReportSystemError(ENOSYS, "%s",
                          _("Cannot create macvlan devices on this platform"));
     return -1;

More information about the libvir-list mailing list