[libvirt] [PATCH 11/12] qemu: command: Refactor NUMA backend object formatting to use JSON objs

Michal Privoznik mprivozn at redhat.com
Thu Jan 29 13:11:32 UTC 2015

On 28.01.2015 11:30, Peter Krempa wrote:
> With the new JSON to argv formatter we are now able to represent the
> memory backend definitions in the JSON object format that is reusable
> for monitor use (hotplug) and then convert it into the shell string.
> This will avoid having two separate instances of the same code that
> would create the different formats.
> Previous refactors now allow to make this step without changes to the
> test suite.
> ---
>  src/qemu/qemu_command.c | 109 +++++++++++++++++++++++++++---------------------
>  1 file changed, 62 insertions(+), 47 deletions(-)

So we will construct a JSON object just to produce a command line? Well,
I am afraid there's no better way if want to use the same code to
generate the monitor commands one day.


More information about the libvir-list mailing list