[libvirt] [PATCH 3/7] virfile: Need to check for ENOTCONN from recvfd failure
eblake at redhat.com
Thu Jan 29 20:15:37 UTC 2015
On 01/28/2015 03:25 PM, John Ferlan wrote:
> A gnulib change (commit id 'beae0bdc') causes ENOTCONN to be returned
> from recvfd which causes us to fall into the throwaway waitpid() call
> and return ENOTCONN to the caller, this then gets displayed during
> a 'virsh save' when using a root squashed NFS environment that's trying
> to save the file as something other than root:root.
> This patch will add the additional check for ENOTCONN to force the code
> into the waitpid loop looking for the actual status from the _exit()'d
> child fork.
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> src/util/virfile.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
ACK. It goes away in your later bigger patch, but doing this makes
backports of a trivial fix without the risk of a refactor bug easier.
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 604 bytes
Desc: OpenPGP digital signature
More information about the libvir-list